Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add demo for buttons with label and icon #8922

Merged
merged 3 commits into from
Oct 31, 2017
Merged

[docs] Add demo for buttons with label and icon #8922

merged 3 commits into from
Oct 31, 2017

Conversation

wongjiahau
Copy link
Contributor

@wongjiahau wongjiahau commented Oct 31, 2017 •
edited by oliviertassinari
Loading

image

Closes #8891

@wongjiahau wongjiahau mentioned this pull request Oct 31, 2017
Closed
@oliviertassinari oliviertassinari changed the title Added demo for buttons with label and icon [docs] Add demo for buttons with label and icon Oct 31, 2017
@oliviertassinari oliviertassinari added component: button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Oct 31, 2017
@oliviertassinari
Copy link
Member

You can run yarn prettier to fix most of the eslint issue.

@wongjiahau
Fix ESLint issue
4cfaacf
@wongjiahau
Fix some ESLint error :
26b32d9 
- missing flow annotation
- no-unused-var
@wongjiahau
Copy link
Contributor Author

@oliviertassinari Already fixed all ES-Lint issues.

@oliviertassinari oliviertassinari merged commit 627c08f into mui:v1-beta Oct 31, 2017
@oliviertassinari
Copy link
Member

@wongjiahau Great work, thank you!

@wongjiahau
Copy link
Contributor Author

@oliviertassinari Welcome!

@wongjiahau wongjiahau deleted the add-demo-for-button-with-label-and-icon branch October 31, 2017 10:56
the-noob pushed a commit to the-noob/material-ui that referenced this pull request Nov 17, 2017
@wongjiahau @the-noob
[docs] Add demo for buttons with label and icon (mui#8922)
906c2ba 
* Added demo for buttons with label and icon

* Fix ESLint issue

* Fix some ESLint error :
- missing flow annotation
- no-unused-var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wongjiahau @oliviertassinari